Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 1 | Exercises - #1295
Open
TTiamiyu wants to merge 13 commits into
Open
Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 1 | Exercises#1295TTiamiyu wants to merge 13 commits into
TTiamiyu wants to merge 13 commits into
Conversation
…e test case for consistency
… empty array, single number, negative numbers, decimal numbers, and non-number values
This comment has been minimized.
This comment has been minimized.
5 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
TTiamiyu
changed the title
This comment has been minimized.
This comment has been minimized.
TTiamiyu
changed the title
This comment has been minimized.
This comment has been minimized.
TTiamiyu
changed the title
This comment has been minimized.
This comment has been minimized.
TTiamiyu
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
TTiamiyu
changed the title
This comment has been minimized.
This comment has been minimized.
TTiamiyu
added
the
Needs Review
cjyuan
added
Review in progress
cjyuan
reviewed
Jul 31, 2026
| @@ -1,4 +1,6 @@ | |||
| function sum(elements) { | |||
| const numbers = elements.filter((item) => typeof item === "number"); | |||
Contributor
There was a problem hiding this comment.
What do you expect from the following function calls (on extreme cases)?
Does your function return the value you expected?
sum([NaN, 1]);
sum([Infinity, -Infinity]);
Author
There was a problem hiding this comment.
No, it wouldn’t return what is expect, i have Incorporated these extreme cases in the test and also improved the sum.js code to cater for such extremes.
cjyuan
added
Reviewed
TTiamiyu
added
the
Needs Review
cjyuan
reviewed
Aug 2, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Changes look good. Well done.
cjyuan
added
Complete
Contributor
|
Note: You missed a Changelist section in your PR description. |
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist